SSENSE / vue-carousel

A flexible, responsive, touch-friendly carousel for Vue.js
https://ssense.github.io/vue-carousel/
MIT License
1.72k stars 504 forks source link

Multi-word component names as per Vue recommendations #521

Open ohepworthbell opened 4 years ago

ohepworthbell commented 4 years ago

Is your feature request related to a problem? Yes. Currently the imported components are Carousel and Slide, which are single-word component names. This goes against Vue's recommendations on naming components (which itself is derived from the fact that custom elements should always be kabab-case, and thus two words to distinguish them from one-word native elements)

Describe the solution you'd like Consider changing Carousel and Slide to CarouselWrapper and CarouselSlide

If any, describe the alternatives you've considered Any other name will also do. Main thing is ensuring consistency and avoiding one word and overly generic component names.

Teachability, Documentation, Adoption, Migration Strategy N/A, though I appreciate this would be a massively breaking change

P.S. Thanks for creating this plugin - just came across it and it's a nice, neat, simple setup.

ohepworthbell commented 4 years ago

Also applicable to Navigation and Pagination child components

demon-zhonglin commented 4 years ago

Maybe you can do this:

import { Carousel, Slide } from 'vue-carousel' Vue.component("Carousel", Carousel); Vue.component("Slide", Slide);