SSENSE / vue-carousel

A flexible, responsive, touch-friendly carousel for Vue.js
https://ssense.github.io/vue-carousel/
MIT License
1.72k stars 504 forks source link

initial work at moving from play to storybook #442 #524

Open ajkovar opened 4 years ago

ajkovar commented 4 years ago

Description

Hi. Found this project on up for grabs and was interested in possibly helping out. Vue play does not seem to be working (at least for me) and that project now seems to be dead so I did some of the initial work at moving to using storybook, which now has vue support.

Any comments/criticisms/etc are welcome. Or feel free to tell me this is a total waste of time. I won't be offended :) I did this more to satisfy my own curiosity/interest.

This PR could possibly be merged as is but other good steps would be to finish moving over the rest of the stories and updating the readme/package.json and any other references to vue play. Let me know if you would like me to take more steps in that direction.

Motivation and Context

https://github.com/SSENSE/vue-carousel/issues/442

How Has This Been Tested?

I updated the snapshots to get the tests passing. Seems like they were broken on master? At least that was what I was seeing. I also had to comment out a test that was failing for me on master. I did that to try and make the pre-commit hooks to pass but they ended up failing anyway, so I had to run it with --no-verify.

Screenshots (if appropriate):

Types of changes

Checklist: