SSENSE / vue-carousel

A flexible, responsive, touch-friendly carousel for Vue.js
https://ssense.github.io/vue-carousel/
MIT License
1.72k stars 508 forks source link

AdjustableHeight Not Working As Expected #604

Open jwbats opened 1 year ago

jwbats commented 1 year ago

Bug Report

Current Behavior AdjustableHeight works whether it is turned on or off.

When turned off, it will only adjust upwards, never downwards.

When turned on, it will only show the proper height when it is explicitly set on the content. It also only ever adjusts upwards, never downwards.

When having a 200px high starting slide, it'll display at 200px high. When you slide to the next 400px high slide, it'll adjust to 400px high. When you slide to the next 200px high slide, it does not adjust back to 200px high.

Input Code and steps to reproduce Just create a basic carousel and put some images of varying height in there.

Expected behavior/code When AdjustableHeight is set to true, I'd expect the height to be properly adjusted for every current slide, like the reference claims it will.

What exactly is supposed to happen when AdjustableHeight is set to false? Are you then supposed to set a height on the carousel itself, and it won't accomodate the slides at all, so they'll overflow (and optionally be hidden)?

Environment Latest.