search

SSHOC / sshoc-marketplace-backend

Code for the backend
Apache License 2.0
2 stars 0 forks source link

clarify which related items are returned #153

Closed dpancic closed 1 year ago

dpancic commented 2 years ago

In GitLab by @stefanprobst on Feb 2, 2022, 22:45

when querying items as Administrator, some items include a huge amount of (duplicate) relatedItems. is this just some weirdness with the -development instance, or are related items included regardless their status when querying as administrator?

example, which includes quite a few duplicate relations to "Twitter" and "Gephi":

curl https://sshoc-marketplace-api.acdh-dev.oeaw.ac.at/api/publications/KzRjeN -H "authorization: ${SSHOC_ADMIN_TOKEN}" | jq '.relatedItems[] | [.persistentId,.label]'
dpancic commented 2 years ago

In GitLab by @vronk on Feb 3, 2022, 13:48

unassigned @vronk

dpancic commented 2 years ago

In GitLab by @vronk on Feb 3, 2022, 13:49

@tparkola, could you comment please?

dpancic commented 2 years ago

In GitLab by @tparkola on Feb 3, 2022, 14:02

Yes, for the Administrator and Moderator related items regardless of their status are returned (even suggested by other contributors).

dpancic commented 2 years ago

In GitLab by @stefanprobst on Feb 3, 2022, 15:28

question is if this is intentional?

EDIT: for the publication example mentioned above it means e.g. that the response payload is 176kb, most of which is due to the 431 (!) included related items, 245 of which are to "Gephi".

it also leads to request times of 20 seconds for this item when requested as admin.

dpancic commented 2 years ago

In GitLab by @vronk on Feb 10, 2022, 14:20

Eliminate multiple relations between two items as discussed.

dpancic commented 2 years ago

In GitLab by @tparkola on Feb 17, 2022, 16:01

As we established for related items the last version is returned for moderator/administrator/system_importer e.g. For contributor the latest APPROVED or related item version where he is InformationContributor to.

Regarding to question about 'cementary' : First create SUGGESTED item by Contributor, then disapprove version by moderator - item status is DISAPPROVED -> Moderator/Administrator can query by GET persistentId/versions/versionId or GET persistentId?approved=false.

dpancic commented 2 years ago

In GitLab by @stefanprobst on Mar 11, 2022, 17:54

not sure if this is the same issue, but with this item i'm kind of seeing the opposite behavior:

when not authenticated, i see two related items:

curl https://sshoc-marketplace-api.acdh-dev.oeaw.ac.at/api/tools-services/sGLPyd | jq '.relatedItems[].persistentId'

"4CL0Rt"
"Y1yxRh"

but when i am authenticated (as contributor), i see none:

curl https://sshoc-marketplace-api.acdh-dev.oeaw.ac.at/api/tools-services/sGLPyd -H "Authorization: ${TOKEN}" | jq '.relatedItems[].persistentId'

EDIT: when authenticated as Administrator or Moderator, i am seeing two related items.

dpancic commented 2 years ago

In GitLab by @vronk on Mar 21, 2022, 13:40

In my understanding, the list of related items should only list each persistentItem once, irrespective of the role, because the related entries point to the persistentItem (and not to the specific versions).

@tparkola, opinions?

(notify: @KlausIllmayer, @laureD19 )

dpancic commented 2 years ago

In GitLab by @stefanprobst on Jun 28, 2022, 11:16

looks like this is no longer an issue. thanks!