search

SSHOC / sshoc-marketplace-backend

Code for the backend
Apache License 2.0
2 stars 0 forks source link

Draft version should be "eliminated" when promoted to suggested #155

Closed dpancic closed 1 year ago

dpancic commented 2 years ago

In GitLab by @vronk on Feb 3, 2022, 14:33

When re-opening, editing and submitting a draft version, it should only push the latest draft version to suggested. The former draft version shouldn't be available anymore.

Opinions @tparkola, @tparkola Notify @KlausIllmayer, @laureD19, @stefanprobst

dpancic commented 2 years ago

In GitLab by @vronk on Feb 3, 2022, 14:33

marked this issue as related to sshoc-marketplace#100

dpancic commented 2 years ago

In GitLab by @stefanprobst on Feb 3, 2022, 15:25

a draft is not connected to a specific item version, i.e. a specific suggestion.

are you proposing that on any PUT request to /:category/:persistentId any existing draft version will be deleted?

dpancic commented 2 years ago

In GitLab by @tparkola on Feb 10, 2022, 12:06

By the former draft version shouldn't be available anymore you mean other contributors draft versions? Right now one contributor can have only one draft version per item. When commited, drafr version is truned into suggested, and no draft is left behind. ' @vronk @stefanprobst

dpancic commented 2 years ago

In GitLab by @vronk on Feb 10, 2022, 14:28

to be handled by frontend (save draft + commit)

dpancic commented 2 years ago

In GitLab by @vronk on Mar 21, 2022, 13:52

@stefanprobst, has this been tackled? (given that we agreed to handle it by frontend)

dpancic commented 2 years ago

In GitLab by @vronk on Mar 21, 2022, 13:53

would that be implemented by https://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/99 ?

dpancic commented 2 years ago

In GitLab by @stefanprobst on Mar 21, 2022, 16:22

yes