draft-items do also show steps #161

Closed dpancic closed 1 year ago

In GitLab by @KlausIllmayer on Mar 2, 2022, 16:23

When calling /api/draft-items it will return also the steps of a draft workflow as separate items:

grafik

But when clicking on the item we run into a 404 as we can't directly call the step. This is not very satisfying for users. I see two solutions: backend does not deliver steps when calling /api/draft-items or frontend hides such steps or changes the url to the workflow.

Which option do you prefer or is there no need to change this @tparkola @stefanprobst ?

Including @egray523 and @laureD19 for further opinions

In GitLab by @stefanprobst on Mar 2, 2022, 16:57

is this happening for newly created entries, or are these leftover stale steps from before https://gitlab.gwdg.de/sshoc/sshoc-marketplace-backend/-/issues/156 was fixed?

In GitLab by @stefanprobst on Mar 2, 2022, 16:59

if this is still an issue i think it should be fixed on backend, instead of hiding steps on the frontend (linking to workflow is not possible since we don't get the workflow id iirc)

In GitLab by @KlausIllmayer on Mar 3, 2022, 14:53

It is happening for newly created entries, I tried it out on dev yesterday with new data and it still shows up.

In GitLab by @tparkola on Mar 9, 2022, 13:57

You want me to hide all draft steps or only draft steps of draft workflow?

In GitLab by @vronk on Mar 21, 2022, 13:42

@laureD19 to review.

In GitLab by @KlausIllmayer on Mar 21, 2022, 14:58

The problem is, that single steps are not clickable on the frontend, as we don't have an endpoint for step-details. Therefore I guess we should hide all steps in the drafts (they are also hidden in other endpoints). I can't think about side effects and it seems @stefanprobst neither. So if @tparkola does also don't see any problem, lets hide all steps in the /api/draft-items endpoint.

In GitLab by @tparkola on Mar 21, 2022, 15:03

@KlausIllmayer Steps was hidden, branch was merged to dev.

In GitLab by @laureD19 on Jun 22, 2022, 10:53

one problem spotted while testing on dev is the following:

creation of a workflow with two steps - ok
save as draft - ok
access the draft via "my draft items" - ok - I see only the workflow in the list of drafts and not the steps. This is how it should be
BUT when clicking on the draft workflow and going on the "preview" mode, I don't see the steps as draft on the item detail view

even though I have two steps as draft that I can see when accessing the 2nd part of the edit form

Would it be possible to display the steps on the draft preview or too complicated @stefanprobst ?

In GitLab by @KlausIllmayer on Jun 28, 2022, 17:19

I can confirm what @laureD19 already checked. Also confirming the problem with not seeing the steps in the preview mode. @stefanprobst do you prefer to have a separate issue on this in the frontend issue or will you give feedback here? I will close the issue when we know about the further steps.

This is solved from perspective of backend:

GET /api/draft-items does not deliver anymore steps GET /api/workflows/{persistentId}?draft=true does deliver the steps

Therefore it looks like frontend has not implemented it and there is already an issue dealing with it: https://github.com/SSHOC/sshoc-marketplace-frontend/issues/129

SSHOC / sshoc-marketplace-backend

draft-items do also show steps #161