search

SSHOC / sshoc-marketplace-backend

Code for the backend
Apache License 2.0
2 stars 0 forks source link

Enabling deleting vocabulary if a concept refers to item media. - [merged] #319

Closed dpancic closed 1 year ago

dpancic commented 2 years ago

In GitLab by @tparkola on Jan 5, 2022, 14:59

_Merges feature/SSHOC-132_delete_vocabulary_item_mediareference -> develop

The goal was to enable deleting vocabulary while one of the concept is refered to by item media entity.

dpancic commented 2 years ago

In GitLab by @tparkola on Jan 5, 2022, 14:59

requested review from @tparkola

dpancic commented 2 years ago

In GitLab by @tparkola on Jan 7, 2022, 08:23

Commented on src/test/java/eu/sshopencloud/marketplace/controllers/vocabularies/VocabularyControllerITCase.java line 753

I suggest to verify here whether the "media[0].concept.code" does not exist, e.g. by adding .andExpect(jsonPath("media[0].concept.code").doesNotExist())

dpancic commented 2 years ago

In GitLab by @tparkola on Jan 10, 2022, 09:08

added 1 commit

Compare with previous version

dpancic commented 2 years ago

In GitLab by @tparkola on Jan 10, 2022, 09:09

mentioned in commit 5242bfc9e18d894d16f8eb52bb104f5ab8976b3e