Check setup for new instances

[KlausIllmayer]

When setting up a new instance of marketplace with the APPLICATION_PROFILE prod I discovered strange prefilled values:

• there should be no users but the system moderator-user was present in the database
• there should be no property-types but the conflict-at-source-property-type was set

It could be, that this is by intention, but I'm not sure about that. This is a minor issue and more for documentation, but it could be interesting to think it through and also to try out a new instance with APPLICATION_PROFILE develop.

[KlausIllmayer]

remark: conflict-at-source must(?) be ord=36 as it is hardcoded in the database-changelog 0056-SSHOC_85-conflict_at_source_property.yaml, that is also the reason that it is present in an empty new instance. the same is true for the user, which is also created in the database-changelog 0050-SSHOC_81-system_moderator.yaml (also with id=5 hardcoded)

@tparkola what do you think about this? should such additions solved differently? it does not look to me as good practice but maybe it is the only solution for adding new users/properties?

[KlausIllmayer]

additional question @tparkola : would it be then wrong to add the property conflict-at-source into https://github.com/SSHOC/sshoc-marketplace-backend/blob/develop/src/main/resources/initial-data/property-type-data.yml as it most probably will get in conflict with the databae-changelog 056-SSHOC_85-conflict_at_source_property.yaml?

[tparkola]

The migrations reflect how the system evolved over time, so probably all the additions/modifications had a reason behind. We could try to organise the changes in a single file, etc. but this introduced risks (see https://docs.liquibase.com/workflows/liquibase-community/trimming-changelogs.html). So unless something is working bad / perform poor I would not spend time on that. Hope that helps.

[vronk]

Maybe revisit in context of some consolidation/overhaul action