search

SSHOC / vocabularies

0 stars 0 forks source link

Error suggesting candidate concepts #22

Closed dpancic closed 1 year ago

dpancic commented 2 years ago

In GitLab by @laureD19 on Oct 27, 2021, 17:31

It is currently not possible to suggest new concept via the edit form. The error message "Failed to suggest concept" appears.

any idea why @KlausIllmayer , @stefanprobst and @tparkola ?

dpancic commented 2 years ago

In GitLab by @stefanprobst on Oct 27, 2021, 17:33

just worked for me on dev.

can you clarify if this is on dev or stage? and could you link to an example? thanks

dpancic commented 2 years ago

In GitLab by @laureD19 on Oct 27, 2021, 17:42

I have tried both on dev and on stage, with a contributor role: item tool-or-service/yxZvbH/ I tried with activity, license and intended audience. It was already reported during the sprint, see the screenshot

image

It could be linked to the user role as I just tried with an admin role on dev and it worked. Item: /tool-or-service/bGJpN6 activity concept added "test tadirah"

dpancic commented 2 years ago

In GitLab by @stefanprobst on Oct 27, 2021, 17:51

with a contributor role

aha!

yep, suggesting an item as contributor currently returns 403 FORBIDDEN.

example: POST https://sshoc-marketplace-api.acdh-dev.oeaw.ac.at/api/vocabularies/discipline/concepts?candidate=true

not sure if this is intentional or not?

dpancic commented 2 years ago

In GitLab by @laureD19 on Oct 27, 2021, 17:54

:) It is not intentional as contributors should be allowed to create candidate concepts

dpancic commented 2 years ago

In GitLab by @KlausIllmayer on Oct 27, 2021, 18:09

That becomes problematic if contributors propose candidate concepts for controlled vocabularies (and most of our vocabularies are controlled ones). I see that we still need the full workflow for vocabularies and candidate concepts before we can discuss who can do what and how we implement this. Currently, there is no formal way to express that a vocabulary is a controlled one. And personally I think that we like to prevent that contributors propose candidate concepts for the TaDiRAH vocbaruly based activity property.

Maybe we should apply the rule for ingestion pipelines: contributors can only add candidate concepts for the keywords. But we then miss the information where contributors originally liked to see this candidate concept. Still a puzzling situation.