search

SSLMate / certspotter

Certificate Transparency Log Monitor
https://sslmate.com/certspotter
Mozilla Public License 2.0
944 stars 84 forks source link

add Message-ID Header #82

Closed andreasschulze closed 8 months ago

andreasschulze commented 8 months ago

Messages are missing a Message-ID header here

Could consider adding one?

I think, somethine like

Message-ID: <$sha_of_cert@certspotter>

would be sufficient (spec)

andreasschulze commented 8 months ago

reading thh spec, it should be

Message-ID: <$sha_of_cert@certspotter.local>

the right part should better look like a domainname

AGWA commented 8 months ago

Would this solve a real-world problem? I would expect sendmail, as the MSA, to add the Message-ID field (https://datatracker.ietf.org/doc/html/rfc6409#section-8.3).

andreasschulze commented 8 months ago

good question: at least using ssmtp I see messages without that header. Forwarding via an MTA that minimize message modifications (thus not adding headers) may fail ...

andreasschulze commented 8 months ago

OK, as you mentioned adding this header is an MSA's job I can't object if you close that ticket.
On the other side it's always a good thing if any software generate well formed messages out of the box.

andreasschulze commented 8 months ago

tested and works ... Thanks!