search

SSLcom / esigner-codesign

GitHub Action for CodeSigner by SSL.com
14 stars 2 forks source link

batch_sign doesn't work if the file has a space in the filename #22

Closed Megamannen closed 7 months ago

Megamannen commented 8 months ago

Just place a file with space in artifcats/unsigned

(running in a windows-latest runner)

- name: Sign Artifact with CodeSignTool
        uses: sslcom/esigner-codesign@v1.3.0
        with:
          command: batch_sign
          username: ${{ secrets.ES_USERNAME }}
          password: ${{ secrets.ES_PASSWORD }}
          credential_id: ${{ secrets.ES_CREDENTIAL_ID }}
          totp_secret: ${{ secrets.ES_TOTP_SECRET }}
          dir_path: ${{ github.workspace }}/artifacts/unsigned
          output_path: ${{ github.workspace }}/artifacts/signed
          malware_block: true
          environment_name: PROD
bayrakmustafa commented 8 months ago

@Megamannen https://github.com/SSLcom/esigner-codesign/blob/develop/.github/workflows/test.yml#L288 where signing with space characters in the file name was tested. Can you test the final version in the develop branch? Also can you share what error you got? Can you share the logs of Github Action?

bayrakmustafa commented 7 months ago

There has been no activity for a long time.