SSNikolaevich / DejaVuSansCode

Monospaced font with programming ligatures based on DejaVu Sans Mono
Other
467 stars 12 forks source link

=> not being converted to ligature #2

Closed gauravkumar37 closed 7 years ago

gauravkumar37 commented 7 years ago

>= is being converted to ligature but => is not.

SSNikolaevich commented 7 years ago

What meaning this sequence has? Should it be converted to some "right arrow" symbol? (For example: VHDL uses this lexeme to describe associations)

gauravkumar37 commented 7 years ago

=> is used in Scala for writing anonymous functions.

Edit: I see that the fork https://github.com/MartinPham/DejaVuSansCode has most of the ligatures added.

SSNikolaevich commented 7 years ago

Implemented in commits 7a4333048ebb88f49dfdc8960a5a12168598ea79 - 5de8aeb0fb3244a106bdaac4ae6972038bc5e4d1

areyes-ut commented 7 years ago

I compiled from master (using make full-ttf), but => is still not being converted in iTerm2 v3.1 beta. Other ligatures are showing just fine, such as !=.

SSNikolaevich commented 7 years ago

I don't have Mac so I can't reproduce this issue. Under Debian with fonts built using make full-ttf on clean working copy all ligatures displayed well. I released fonts with resent changes. Could you try it?

adityavm commented 7 years ago

Just wanted to add that the LGC version doesn't show the => ligature, but full version does

SSNikolaevich commented 7 years ago

I tested LGC version in Atom and IDEA under Debian today and didn't face any problems.

adityavm commented 7 years ago

@SSNikolaevich I'm on a Mac

areyes-ut commented 7 years ago

@SSNikolaevich Sorry, I tried the tarball for 1.2.1, and it is still not showing a hashrocket ligature for me in iTerm2, v3.1 beta.

SSNikolaevich commented 7 years ago

Finally checked 1.2.1 LGC version on Mac OS 10.12.5, iTerm Build 3.1.beta.6. All ligatures are displayed well.

areyes-ut commented 7 years ago

@SSNikolaevich What shell and application (e.g. vim, emacs, whatever) are you using to check? What's your locale setup? If I just use echo in a zsh shell, it still won't work with =>. My locale variables are set to en_US.UTF-8.

areyes-ut commented 7 years ago

I am using OSX Yosemite, 10.10.5 .

SSNikolaevich commented 7 years ago

Mac OS Sierra 10.12.5 iTerm Build 3.1.beta.6 GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin16) VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Apr 4 2017 18:14:54) ru_RU.UTF-8