Lack of SSLv2 is not detected properly

SSPkrolik / smtp

SMTP library for D

MIT License

8 stars 6 forks source link

Lack of SSLv2 is not detected properly #2

Closed opticron closed 9 years ago

opticron commented 10 years ago

When attempting to compile with OpenSSL that lacks SSLv2 support, smtp fails to build because SSLv2 code is not excluded properly. The relevant code is in smtp/ssl.d in the switch statement in the SocketSSL constructor. Changing the version statement to key off of OPENSSL_NO_SSL2 does not fix the problem as that version is not defined. I'll poke at things in the mean time and I'm available to test patches if you have suggestions.

KrzaQ commented 10 years ago

You can use ssl_no_ssl2 version, it works.

opticron commented 10 years ago

That is what is currently being used and it does not work unless you're saying that I need to specify this manaully.

KrzaQ commented 10 years ago

Yeah, I meant that you'd have to specify it manually. It fixed the problem for me.

SSPkrolik commented 9 years ago

Added one more configuration: ssl-no-ssl2 for smtp lib itself for no-ssl2 builds of the OpenSSL library.