search

SSSD / sssd-ci-containers

Setup containerized environment for testing and developing SSSD.
GNU General Public License v3.0
10 stars 21 forks source link

build: disable nscd if present #64

Closed sumit-bose closed 1 year ago

sumit-bose commented 1 year ago

On some platforms nscd might be pulled in and started via dependencies. Since running SSSD together with nscd is not supported it should be disabled if present.

pbrezina commented 1 year ago

Thank you. LGTM. Can you move it to common please? That seems to be a better place.

sumit-bose commented 1 year ago

Thank you. LGTM. Can you move it to common please? That seems to be a better place.

Hi,

I think common is run too early. I guess nscd is install as a dependency during Install SSSD build and integration tests dependencies and has to be disabled afterwards. Do you have any other suggestions where to put it?

bye, Sumit

pbrezina commented 1 year ago

I see. Maybe we can add new role here: https://github.com/SSSD/sssd-ci-containers/blob/master/src/ansible/playbook_image_service.yml#L6

This will make sure it is called only once and after all packages are installed.

sumit-bose commented 1 year ago

I see. Maybe we can add new role here: https://github.com/SSSD/sssd-ci-containers/blob/master/src/ansible/playbook_image_service.yml#L6

This will make sure it is called only once and after all packages are installed.

Hi,

this is too early as well. Install SSSD build and integration tests dependencies is one of the very last steps of building client-devel and as long as the packages are not installed the service cannot be disabled.

bye, Sumit

pbrezina commented 1 year ago

Ah, I misunderstood it. I suppose it is pulled by nslcd package and it is installed in a wrong place for Debian and Ubuntu.

It should be in Install packages for client base image since it is a requirement to run multihost/system tests. Fedora has it (nss-pam-ldapd) on correct place. https://github.com/SSSD/sssd-ci-containers/blob/master/src/ansible/roles/packages/tasks/Fedora.yml#L121 Jakub shifted some packages but only for Fedora, we should also do the same for Debian and Ubuntu. For now, it will be enough to just move the nslcd package.

Install additional packages for client development image is about installing development packages, needed to build SSSD and run integration tests, but not needed for the multihost/system tests.

sumit-bose commented 1 year ago

Hi,

ok after moving nslcd and slapd to Install packages for client base image it was working with a new role. Do you prefer the new role or should it be better in common ?

bye, Sumit

pbrezina commented 1 year ago

Thank you, ack.