SSSD / sssd-ci-containers

Setup containerized environment for testing and developing SSSD.
GNU General Public License v3.0
10 stars 21 forks source link

Fixes and improvements for package installation during image builds #77

Open dpward opened 8 months ago

dpward commented 8 months ago

These changes make image building more consistent between different distributions, by fixing discrepancies and re-using task lists where appropriate. (The task lists for RHEL now include those for CentOS; and the task lists for Ubuntu now include those for Debian.) This is intended to simply maintenance and allow for easier testing with other base images.

This also improves the build speed. Temporary volumes are now created and mounted at the paths where repository metadata is stored, so that it does not need to be re-downloaded for each image that is built (ipa, ldap, etc.) For Debian/Ubuntu, this metadata is now re-used across different package management operations for the same image.

Builds were performed successfully from these base images:

pbrezina commented 8 months ago

Wow, that's a lot of patches thank you. I'll let PR CI run and then review it if there is no major issue.

pbrezina commented 8 months ago

Hmm, PR CI errors are not related to this pull request. It seems that some update started to cause issues when commiting to containers in the github runners. I need to look into it first.

pbrezina commented 8 months ago

Hopefully, I fixed all PR CI issues, can you please rebase this pull request?

pbrezina commented 8 months ago

Also, I am curious, what is your motivation behind this pull request? How are you using this project? Thank you.

dpward commented 8 months ago

Also, I am curious, what is your motivation behind this pull request? How are you using this project? Thank you.

These containers are useful in helping others reproduce specific issues we observe in SSSD, in a controlled manner. This pull request fixes inconsistencies that make it difficult to rebuild the images as necessary, in order to accomplish that. We are concerned with multiple versions of RHEL and Ubuntu primarily.

The comments here may provide an example of why this is useful: https://bugs.launchpad.net/ubuntu/+source/sssd/+bug/2051388

andreboscatto commented 5 months ago

Hi @dpward

It has been a while since we left a few comments in this PR, will you be able to review those? If there is anything we can do to help, please let us know.

Kind regards