✨ New Rule - Emojis having spaces

SSWConsulting / SSW.CodeAuditor

SSW Code Auditor V2

6 stars 6 forks source link

Closed piers-sinclair closed 5 months ago

piers-sinclair commented 6 months ago

Cc: @adamcogan @tiagov8

Hi @tombui99

I just noticed that a rule I edited didn’t have spaces between emojis and text. https://www.ssw.com.au/rules/turn-emails-into-pbis/

Figure: No spaces on emojis in this rule should be caught by CodeAuditor

Thanks!

tiagov8 commented 6 months ago

cc @adamcogan

Hi @piers-sinclair

❌ This Issue is technically wrong !

The example you used is an image via CSS class "good"... IT IS NOT an emoji!

This CANNOT be caught by CodeAuditor, since it isn't a HTML space, but CSS margin

[ ] 1. Please make sure you understand the above
[ ] 2. Please read this email thread: Re: Spaces needed after emojis
[ ] 3. Please read my comment on other Issue: https://github.com/SSWConsulting/SSW.CodeAuditor/issues/443
[ ] 4. Close this Issue