search

SSWConsulting / SSW.CodeAuditor

SSW Code Auditor V2
6 stars 6 forks source link

🐛 Custom Rule - Warning URL link to root should be ignored #879

Closed andrewwaltosssw closed 5 months ago

andrewwaltosssw commented 5 months ago

Cc: @tombui99

Hi Tom

Describe the Bug

Report shows Code Warning for violating Links - URLs should not include full stop or slash at the end however there are cases where we use a single slash to reference the root URL

Image Figure: Screenshot of code snippet tagged for violating URL ending in slash rule

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://codeauditor.com/htmlhint/6a99477f-c494-4705-5fe1-6e3be7823f72
  2. Click on: Image Figure: screenshot of Code results pointing to SVG element violation
  3. See error

Expected Behavior

Expecting references to root to not raise this error type

Tasks

More Information

Environment

Thanks!

tombui99 commented 5 months ago

cc @andrewwaltosssw @adamcogan @william-liebenberg

Investigate and Fix

Done - Custom rule was fixed to ignore root urls /

See latest scan on https://tina.io/ where the false positive is no longer reported https://codeauditor.com/htmlhint/6e05cf30-a328-4ae1-d68a-e0ed5494d0c8?displayMode=0