search

SSWConsulting / SSW.Dory

SSW.Dory - Sharepoint and GitHub
http://sswdory.com
1 stars 0 forks source link

✨ Email Frequency - Respect Client Bookings #68

Open danielmackay opened 1 year ago

danielmackay commented 1 year ago

Cc: @leahy268 @drwharris @bradystroud

Hi @Jord-Gui

Pain

Currently, the emails will get sent to everyone assigned to the PR. However, client work should take priority and devs should not be interrupted when booked.

Suggested Solution

Look up if developers are booked on client work (similar to the Booked In Days Report). Only send the email, if they are NOT booked on client work.

Devs on client work can still be assigned to review PRs. But ideally we should not hound them when on client work.

Acceptance Criteria

  1. SSW.Dory emails are not sent to devs that are booked on client work

Thanks!

bradystroud commented 1 year ago

Hey @danielmackay

I agree that devs assigned to client work who are added as reviewers should not be notified, but if a dev makes a PR, they should be responsible for merging, or at least handing it over to someone else to get done.

Another odd case is after a reviewer has requested changes, their approval is then required. If you are on client work, but your approval is blocking the PR from being merged, then you should be notified.

drwharris commented 1 year ago

Hey @Brady Stroud @.***>,

As discussed, GitHub allows you to “Dismiss Review” if required to unblock you and allow someone else to review in that “unavailable” persons place.

Andrew Harris | SSW Solution Architecthttp://www.ssw.com.au/People/Andrew-Harris?utm_source=emailsignature | +61 418 599 547https://www.ssw.com.au/ssw/Company/Offices/?utm_source=emailsignature | Ping me on @.***>

From: Brady Stroud [SSW] @.> Sent: Monday, September 25, 2023 7:48 PM To: SSWConsulting/SSW.Dory @.> Cc: Andrew Harris [SSW] @.>; Mention @.> Subject: Re: [SSWConsulting/SSW.Dory] ✨ Email Frequency - Respect Client Bookings (Issue #68)

Hey @danielmackayhttps://github.com/danielmackay

I agree that devs assigned to client work who are added as reviewers should not be notified, but if a dev makes a PR, they should be responsible for merging, or at least handing it over to someone else to get done.

Another odd case is after a reviewer has requested changes, their approval is then required. If you are on client work, but your approval is blocking the PR from being merged, then you should be notified.

— Reply to this email directly, view it on GitHubhttps://github.com/SSWConsulting/SSW.Dory/issues/68#issuecomment-1733328127, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEVZEVDQOEARBC67RHNRLRDX4FHL7ANCNFSM6AAAAAA5CJSJZQ. You are receiving this because you were mentioned.Message ID: @.***>