SSWConsulting / SSW.Rules.Content

Secret ingredients to quality software
46 stars 174 forks source link

Images - Missing alt text #345

Open bradystroud opened 3 years ago

bradystroud commented 3 years ago

cc: @JackLeerson @adamcogan Hi @tiagov8,

CodeAuditor is finding some errors in the HTML where images do not have alt text. https://htmlhint.com/docs/user-guide/rules/alt-require

You can see all the rules with images missing alt text here.

2021-03-22_14-38-02 Figure: Image missing alt text

The alt text can be easily added in the Markdown using this syntax:

![Figure: Good figure](https://images.unsplash.com/photo-1491472253230-a044054ca35f)
  1. Please go through all the rules and add alt text (figure statements)

Thanks,

-Brady

AB#60567

tiagov8 commented 3 years ago

Hey @bradystroud ,

It seems like the very first issue has an issue 🤓 :

Screen Shot 2021-03-23 at 5 09 37 PM Screen Shot 2021-03-23 at 5 13 05 PM

See how the syntax seems alright:

https://www.ssw.com.au/rules/login-security-do-you-know-the-correct-error-message-for-an-incorrect-user-name-or-password

Screen Shot 2021-03-23 at 5 09 20 PM
  1. Please investigate why this Markdown was not converted to an "alt"
  2. Make sure it's fixed and give me a new CA report to fix
  3. I noticed we have some images in rules where we don't want captions... how would we have them if we need this syntax?

Cheers, Tiago