Closed babakamyljanovssw closed 1 month ago
cc: @JackDevAU @bradystroud
I will be checking invocation list of these functions on Friday, and if there are no any new calls, then I proceed with merge.
@bradystroud @tkapa @JackDevAU
Update
The UpdateLatestRules
functions wasn't being used after last time I checked which is good and can be removed safely, but the GetLatestRules
function was called a few times.
Figure: A few calls made to function after last check
Not sure where it is being called from, this function was being used in widget, but we have updated widget to new version to use history.json
.
I checked the request logs for this function before widget upgrade and after widget upgrade for the 7 day period:
Currently investigating where these calls are made from
Hi @bradystroud,
While investigating Azure Functions I checked GetLatestRules
and UpdateLatestRules
functions usage, both of them weren't used for the last 7 days. If there is nothing else I will proceed with merging this PR.
Figure: Application Insights logs returned empty resulted for these functions
Relates: https://github.com/SSWConsulting/SSW.Rules/issues/1438
As we have made changes to Latest Rules widget to use
history.json
andcommits.json
as it's data source, we are no longer need the functions and entity context used by widget previously.Changes:
GetLatestRules
andUpdateLatestRules
functionsLatestRules
entity fromRulesDbContext
docs/Functions/Functions.http
located in root folder as it is duplicate withdocs/Functions/Functions.http
insideSSW.Rules.AzFuncs
projectFigure: UpdateLatestRules was called last time 19th September
Figure: GetLatestRules was called last time 21st September