SSWConsulting / SSW.Rules

Generator for ssw.com.au/rules
https://www.ssw.com.au/rules
MIT License
15 stars 13 forks source link

๐Ÿ› Rules heading style different in Chrome and Safari #1400

Closed jeoffreyfischer closed 3 months ago

jeoffreyfischer commented 3 months ago

@bettybondoc @jaydenalchin @tiagov8

Describe the Bug

On SSW Rules, the heading style is different in Chrome and Safari:

To Reproduce

Steps to reproduce the behavior:

  1. In Chrome, go to a rule, e.g. https://www.ssw.com.au/rules/event-storming-workshop/
  2. In Sarfari, go to the same rule https://www.ssw.com.au/rules/event-storming-workshop/
  3. Observe the different in heading styles

Expected Behavior

The heading should have the same style regardless of the machine OS. That style should be the one on Safari i.e. with bold / semi-bold headings

Tasks

Screenshots

Image Figure: Rule on a Windows

Image Figure: Rule on a Mac

Thanks!

tiagov8 commented 3 months ago

Hi,

FYI - the rendering issue is not on OS , but the browser. On my Mac it looks thinner on Chrome and Bolder on Safari (same OS)

Looking at the CSS there are no problems ๐Ÿคจ .. seems like Safari just renders font-weight: 500 used on headings differently (bolder).

PS. On Edge for Mac the font looks thinner too, like Chrome.

Unfortunately I couldn't find any solution yet ...

--

That style should be the one on Mac i.e. with bold / semi-bold headings

โš ๏ธ Important: Please follow @jaydenalchin instructions before making any styling changes. The font-weight should follow his guide.

--

Screenshots on Tiago's Mac

Safari:

Image


Chrome:

Image

Edge:


Image

jeoffreyfischer commented 3 months ago

Thanks @tiagov8 , I will get @bettybondoc and @jaydenalchin to confirm that they're happy with the style on each browser ๐Ÿ‘

bettybondoc commented 3 months ago

cc @tiagov8 @jeoffreyfischer @jaydenalchin

I'm also confused about this issue.

On my Mac, they're okay (bold) on both Chrome and Safari

Image

Figure: Chrome

Image

Figure: Safari

tiagov8 commented 3 months ago

Hey @bettybondoc

Can you confirm you have Open Sans installed in your machine? If not, can you install and do the test again

All,

I am pretty sure the examples we see bolder are Helvetica... while the thinner ones are Open Sans.

The easiest way to spot the difference is on the question mark dot:

I believe our website is not "calling" the Open Sans font from web, so it shows only for the users who have it installed.

More info: https://www.w3schools.com/css/css3_fonts.asp

That is what we need to fix :)

Image

Figure: Toggle between fonts clearly shows the issue

Image

Figure: The CSS set for the website... Open Sans first, then Helvetica

jeoffreyfischer commented 3 months ago

โœ… Done - this PBI was fixed in #1399

bettybondoc commented 3 months ago

@tiagov8 cc @jeoffreyfischer @jaydenalchin

Can you confirm you have Open Sans installed in your machine? If not, can you install and do the test again

Yeah, you're right! When I installed Open Sans, it behaves the same way with yours now (bold in Safari, normal in Chrome) ๐Ÿ˜ฌ But I think this will be fixed once @jeoffreyfischer merges his changes re Issue https://github.com/SSWConsulting/SSW.Rules/issues/1399

Image

Figure: Chrome

jeoffreyfischer commented 3 months ago

โœ… Done - this PBI was fixed in #1399