search

SSWConsulting / SSW.Rules

Generator for ssw.com.au/rules
https://www.ssw.com.au/rules
MIT License
15 stars 13 forks source link

♻️ Fix Images extensions with capitalization #1431

Closed tiagov8 closed 1 month ago

tiagov8 commented 2 months ago

Converted to its own Issue since the rest of broken images not necessarily have this problem.

Original message from @RobJT-wq :

Setup - Do you use two monitors? | SSW.Rules

Can't seem to load this image in chrome/edge or firefox tried to edit in github/netlify as I thought the link might be broken but it shows in the markdown without any issues.

Any Ideas?

Image Image

Then @tiagov8 fixed it by renaming the image from (TwoMonitorsBetterThanOne.JPG) to (two-monitors-better-than-one.jpg) in this PR: https://github.com/SSWConsulting/SSW.Rules.Content/pull/9055

We want to avoid other occurances, so this comment was left on another Issue:

(Checked by @kikibianc )

As per my conversation with @tiagov8

Hi @bradystroud

It looks like capitalisation breaks image links https://github.com/SSWConsulting/SSW.Rules.Content/pull/9055

  1. Can you find and rename the images with capitalisation?

Originally posted by @RobJT-wq in #8328

tiagov8 commented 2 months ago

Note: Added an extra tip on https://www.ssw.com.au/rules/how-to-name-documents/

PR: https://github.com/SSWConsulting/SSW.Rules.Content/pull/9060

tiagov8 commented 2 months ago

Another example of a broken image I had to fix by updating filename extension to lowercase https://github.com/SSWConsulting/SSW.Rules.Content/pull/9116

babakamyljanovssw commented 1 month ago

cc: @tiagov8 @bradystroud @JackDevAU

✅ Done - PRs to fix image extension issue:

babakamyljanovssw commented 1 month ago

cc: @bradystroud @JackDevAU @tiagov8

Update:

✅ Added logic to prevent merging PRs to SSW.Rules.Content repo with images that contains capital case extensions. https://github.com/SSWConsulting/SSW.Rules.Content/pull/9215

✅ Drafted new Issue https://github.com/SSWConsulting/SSW.Rules/issues/1490 for adding validation to image upload widget

As this PBI fixed images with capital extensions, I'm closing it 🙂