SSWConsulting / SSW.Website

Generator for ssw.com.au
https://www.ssw.com.au
Apache License 2.0
8 stars 7 forks source link

🐛 BUG UI - How come we have a blue-ish 🟦 footer?! #1609

Open tiagov8 opened 11 months ago

tiagov8 commented 11 months ago

cc @jaydenalchin @hveraus @adamcogan @bradystroud

Describe the bug I noticed the ssw.com.au footer is blue-ish...

I'm not familiar with Toastify, but apparently it is the cause of this...

Expected behavior Only use SSW Colors https://www.ssw.com.au/ssw/company/Web-Reference.aspx#Colors

Screenshot 2023-10-24 at 3 06 11 PM Screenshot 2023-10-24 at 3 11 08 PM
tiagov8 commented 11 months ago

Just noticed the bug is even worse in the Events widget...

Screenshot 2023-10-24 at 3 24 43 PM
bradystroud commented 11 months ago

Hey @tiagov8

FYI this wasn't caused by Toastify, it was a dev mistake.

  1. How did this happen?

This must have been missed in code review. There was a line from the tailwind config commented out causing some components to go into dark mode

https://github.com/SSWConsulting/SSW.Website/blob/dcb3e173d4c5a1111f6ef67d057abeddfa7b0e35/tailwind.config.js#L12

  1. Please fix the color

Done in #1613

bradystroud commented 11 months ago

Hey @tiagov8

I discovered another instance of this problem Working on it in #1615

Image Figure: More blue

tiagov8 commented 11 months ago

Hi @bradystroud

I think this too:

Screenshot 2023-10-26 at 1 37 11 PM

I think it is important to check and fix every single color on the root of the CSS to be SSW colors.

We don't want to be fixing every intance we find...

bradystroud commented 11 months ago

Hey @tiagov8

They were all the same problem but I didn't merge the fix - Anywhere gray was used will be fixed once the changes from #1615 are merged

bettybondoc commented 6 months ago

cc @amankumarrr

Hey @bradystroud 👋

https://ssw.com.au/company/contact-us

I was on a call with @tiagov8 when we noticed that the link text on the Contact Us page also uses a bluish-grey colour.

image Figure: Link text using bluish grey #11827

Calinator444 commented 5 months ago

CC: @wicksipedia

Hey @tiagov8

Is this issue still relevant? If not could we close it please? Just looking for bugs in the backlog and not sure which are still relevant

Thanks

tiagov8 commented 5 months ago

Hi @Calinator444

Yes, still relevant, the color for links is still wrong:

Image