SSWConsulting / SSW.Website

Generator for ssw.com.au
https://www.ssw.com.au
Apache License 2.0
7 stars 5 forks source link

💸 Newsletters pages under /images/ folder?! #2232

Open tiagov8 opened 4 months ago

tiagov8 commented 4 months ago

cc @bradystroud @BrookJeynes @wicksipedia

Description

Hi Team,

looking at a Google Tag Manager report from @camillars I noticed this bunch of links under https://www.ssw.com.au/images/newsletter-uploads/...

For a moment I thought it was a bug, but navigating from https://www.ssw.com.au/newsletters I confirmed the newsletters pages are actually under an /images folder...

Proposed solution

Screenshots

Screenshot 2024-03-04 at 12 13 09 PM Screenshot 2024-03-04 at 12 13 19 PM
Harry-Ross commented 4 months ago

Be very careful whoever is working on this - last time I was working on fixing this when I originally implemented the image upload, it broke all images on the site:

https://github.com/SSWConsulting/SSW.Website/pull/821#discussion_r1233450868

Calinator444 commented 2 months ago

As per my conversation with @amankumarrr Fixing this would be difficult to do right now because changing the route from "/images" also changes the upload directory on "https://assets.tina.io/".

It would be better to fix this when we have media manager integration for Tina

andrewwaltosssw commented 2 months ago

Do this work after v1 website VM has been switched off