SSWConsulting / SSW.Website

Generator for ssw.com.au
https://www.ssw.com.au
Apache License 2.0
8 stars 8 forks source link

🔗 Footer - fix Health Check/Sitemap links #2911

Closed Calinator444 closed 2 months ago

Calinator444 commented 2 months ago

Description

The health check/sitemap links in the footer point to the health check/sitemap form the asp.net server. These pages are no longer accessible because Cloudflare worker is sitting in from of the route to the old server.

- [x] Add a todo page page for adding a HealthCheck for the website
- [x] Add a todo page for adding a Sitemap (not to be mistaken with the sitemap used by Google to index our pages)
- [x] Update the HealthCheck in our footer to go to the todo page (/healtcheck)
- [x] Update the Sitemap link in our footer to go to the todo page (/sitemap)

Screenshot

Image

Figure: Footer for SSW Website

Image

Calinator444 commented 2 months ago

@wicksipedia updated this as per our conversation

Calinator444 commented 2 months ago

@wicksipedia

I've created a couple of placholder pages for both pages and gotten the designs reviewed by @tiagov8

Happy to roll the placeholders and add redirects depending on whether you want to have a health check on the site n the future.

Calinator444 commented 2 months ago

@wicksipedia

Done - I added placeholder pages for /healthcheck and /sitemap, updated the links at the source, and added redirects for the old pages.

See links to new pages:

Image

Figure: Fixed link for HealthCheck

Image

Figure : Fixed link for sitemap

I had trouble merging because I needed to fix these unit tests that were failing because they hadn't been updated after playwright had been updated on our repo

https://github.com/SSWConsulting/SSW.Website/pull/2918/files#diff-074c15b643ffe7c436d49396bc3729866ce6ae365dff06bec9af1f32bde37c4e

https://github.com/SSWConsulting/SSW.Website/pull/2918/files#diff-327c954afae419258520480a57498ea57177bc4f11113420475d2d3a61231e26

https://github.com/SSWConsulting/SSW.Website/pull/2918/files#diff-074c15b643ffe7c436d49396bc3729866ce6ae365dff06bec9af1f32bde37c4e