search

SSWConsulting / SSW.Website

Generator for ssw.com.au
https://www.ssw.com.au
Apache License 2.0
9 stars 8 forks source link

⚡LiveStream Banner - Add static fetching for live stream events #3108

Closed Calinator444 closed 1 month ago

Calinator444 commented 1 month ago

CC: @wicksipedia

Description

All pages on the site perform a client side fetch to check for upcoming livestream events. This increases the time taken for the banner to appear.

Note: I completed this in an attempt to improve our TBT (see 🔍 SEO - Reduce Total Blocking Time ), but as per my conversation with Aman this is unlikely to reduce TBT since the fetch is deferred. Creating this PBI to log the work.

Calinator444 commented 1 month ago

Note: while completing this PBI I also fixed a bug where the live stream widget was attempting to display non-existent information about an external speaker. In addition I fixed the link to the live stream banner while performing this change

Image Figure: ❌Broken Live stream widget for external presenter


Image

Figure: ✅ Live stream banner hides the about section for external presenters

Image Figure: ❌Broken live stream banner image


Image

Figure: ✅Fixed live stream banner link

Calinator444 commented 1 month ago

CC: @wicksipedia

Done - the live stream banner loads almost instantaneously now.

Image

Calinator444 commented 1 month ago

Todo - confirm whether the live stream banner will show when the event time ticks over

Calinator444 commented 1 month ago

@wicksipedia just tested locally and the event banner will display when the appropriate display time ticks over.

The banner won't display if there's no livestream at build time, but we rebuild the site every time we add a live stream anyway.

Image

Figure: Live stream banner showing at appropriate time