SSantosLab / TreasureMap

Scripts to send DECam pointings to TreasureMap
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Defend against GW events with overlapping nights #3

Open rmorgan10 opened 4 years ago

rmorgan10 commented 4 years ago

Currently if multiple GW events are being triggered over the same range of nights, query_tm.py will group all the pointings together since it only selects on NITE and PROPID. The query needs to be made specific to the GW event.

rmorgan10 commented 4 years ago

Possible approaches:

rmorgan10 commented 4 years ago

To implement a solution, the easiest way is writing more command-line arguments to pass to the query

mssgill commented 4 years ago

It's of course in theory possible that the events could overlap in localization so the same pointings could be used for both searches, and in that case it doesn't matter much which event they're identified with. But i guess officially each pointing will be for a particular event, so i think the GraceDB ID string kind of makes the most sense..?

rmorgan10 commented 4 years ago

The drawback of that is it depends on making sure the gracedb id is in the observing scripts. If that is ever forgotten then it could break these scripts depending on how that field is handled.

I think I'd like the default way to be as the query script is now, and then have additional command-line arguments for making the DB query more specific in the event that we are dealing with GW pointings that overlap in space / time.

mssgill commented 4 years ago

Ok, that makes sense too, and sounds good..