Thank you for breaking Applications

[LKaemmerling]

Hey,

i just want to thank you, that you break Applications that use your Package!

Because of your change (the stuff with the Incoming Message Class) a big application doesn't work anymore, and it isn't possible to jump back to an version that works. Thanks for this!

[mattparksjr]

Hello! We do not modify any environment variables so this is not possible. Even so it is good practice to use a service like git to make multiple versions of a project,

[LKaemmerling]

Sure, but you modified the thing in development before release. Just git tag the stuff, so that it is possible to jump back to an old version, currently it isn't possible because you develop on "dev" & "master" & "2.0" ?

[mattparksjr]

Old versions cannot be supported and really REALLY should not be used

[LKaemmerling]

Because of what? Commit fcb7a68 works complety fine for me, but because of your changes it isn't possible to use this specific commit anymore because you doesn't tag the package. It isn't a good practice to make changes that can break applications (because the return of getMessages() isn't an array anymore) on the master branch, and if somebody composer update his own source code: it suddenly doesn't work anymore because of you changes!

[mattparksjr]

General code issues. It worked, but a lot of "WIP" comments and code that does not work was in there. Also, attachments did not work on most servers. Docs were not up to date at the time and generally, the code was bad. Do note that commits is VERY old and the new class structure is must easier, more efficient and supports most servers. In the future, we will make changes to the dev branch. This was not set before and this library basically was rebuilt. We are worried about supporting as much as we can. However, that commit is very old and due to the class structure, we simply cannot support that old class. I recommend that you look through the code and find where you reference our library, read our new docs and recode those bits. Sorry for the inconvenience.

[LKaemmerling]

Sure that would be the best solution, but also it would be better if you git-tag the versions,

[mattparksjr]

Ill be sure to work that in. We are also going to, starting at version 2.0, notify all devs of big API changes,

[mattparksjr]

You can check the archive folder for now

[sergey144010]

You can clone the repository and roll back the changes before the commit that you need. And getMessages() returns an array, but only objects.

[MrSinor]

@sergey144010 @xXXIMMATTHEWXXx Thank you for breaking Applications I updated files and all of my codes give me error. You Shit in codes. :|

[sergey144010]

Which errors?

[MrSinor]

he... compare a week ago getMessage function with now. all structure changed

[mattparksjr]

We have solved this issue. Useless ranting that people can barely read is not needed. I will close this issue asap