SSoelvsten / adiar

An I/O-efficient implementation of (Binary) Decision Diagrams
https://ssoelvsten.github.io/adiar/
MIT License
24 stars 13 forks source link

bdd_sink, bdd_ithvar, ... are not canonical #129

Closed SSoelvsten closed 2 years ago

SSoelvsten commented 3 years ago

All the functions in bdd/build.h are not canonical in the sense, that their id are not from MAX_LABEL and decreasing, and they are (maybe?) not sorted based on their children.

SSoelvsten commented 3 years ago

128 Has solved this for all but the adiar::counter function. I don't think it is worth the effort to make it canonical; especially since the constructed BDD is (relative) small in size. So, this will be closed together with the merge of that feature branch.