SSoelvsten / bdd-benchmark

Benchmarking Suite for BDD packages
MIT License
11 stars 2 forks source link

McNet : Invalid label used during BDD construction #123

Closed SSoelvsten closed 3 months ago

SSoelvsten commented 3 months ago

For the AEON benchmarks, 04][r166][ETC]__[covidunilu].out has the following exception thrown by the builder.

{
  "debug_mode": false,
  "statistics": false,

  "bdd package": {
    "name": "Adiar",
    "type": "BDD",
    "init time (ms)": 2,
    "memory (MiB)": 353280,
    "variables": 208
  },

  "benchmark": {
    "name": "mcnet",
terminate called after throwing an instance of 'std::invalid_argument'
  what():  Cannot represent that large a label

A similar exception is in the log for the BNET klamt_tcr.out, arellano_rootstem.out, calzone_cellfate.out, and many many more.

SSoelvsten commented 3 months ago

This turns out to be an error in using Sloan's algorithm. Specifically for klamt_tcr.bnet, variables x0 and x1 are in a separate component which is relabelled. But, the ordering algorithm does not explore the remainder of the graph.