SSteve / f-scott-fitzgerald_this-side-of-paradise

This Side of Paradise for Standard Ebooks project
Other
0 stars 0 forks source link

<i> missing semantics #5

Closed acabal closed 6 years ago

acabal commented 6 years ago

There are more than a few instances of <i> being used without semantics. When referring to books, journals, newspapers, etc., please include the relevant epub:type se attribute. For example, the <i epub:type="se:name.publication.newspaper">Princetonian</i>. You can read the vocabulary here: https://standardebooks.org/vocab/1.0

SSteve commented 6 years ago

@acabal There are a couple places where he abbreviated Princetonian to Prince. I wrapped those in abbr tags like this:

<i epub:type="se:name.publication.newspaper"><abbr class="contraction">Prince</abbr></i>

Is that correct?

SSteve commented 6 years ago

@acabal How about when he abbreviates Nassau Literary Magazine to Nassau Lit.? Do I put abbr around just Lit.?

acabal commented 6 years ago

Re. Prince, I don't think it's necessary to put an <abbr> tag there, since there's no period or apostrophe. But yes, for "Lit." you can just wrap it in <abbr> without any class.

SSteve commented 6 years ago

@acabal He he uses “Lit.” at the end of a sentence. Would I make that <abbr class=“eoc”>?

acabal commented 6 years ago

Yes exactly!

SSteve commented 6 years ago

@acabal A last couple <i> tags without semantics:

<p>“Now, Langueduc, if I used that formula, where would my <i>A</i> point be?”</p>

They wore black armbands with orange “<i>P</i>’s,”

Is <i> without semantics correct for these?

acabal commented 6 years ago

Yes, per the typography manual that is one of the very few cases where unsemantic <i> is correct :)

On December 16, 2017 12:10:49 PM CST, Steve notifications@github.com wrote:

@acabal A last couple <i> tags without semantics:

<p>“Now, Langueduc, if I used that formula, where would my <i>A</i> point be?”</p>

They wore black armbands with orange “<i>P</i>’s,”

Is <i> without semantics correct for these?

SSteve commented 6 years ago

Done.