search

STAMP-project / camp

Amplify your Configuration tests!
https://stamp-project.github.io/camp
MIT License
10 stars 8 forks source link

Inconsistent build reference in the generated docker-compose file #55

Open mboussaa opened 5 years ago

mboussaa commented 5 years ago

Characteristics

Description

When generating two configs, it seems that the generated docker-compose file for one of the two generated configs is erroneous. In the build: parameter of generated compose, the reference to the right dockerfile file is not always correct. It does correctly the changes for one configuration but not for the other. I had to define the changes manually in camp.yml to make this working as below:

          - targets: [ docker-compose.yml ]
            pattern: "build: ./springpetclinicMS"
            replacements: [ "build: ./images/springpetclinicpg_0" ]

However, I didn't need to define the replacements for the other config as it was correctly generated, defining the right build reference.

Steps to reproduce

-generate 2 configs. -check if the the build parameter in the generated dokcer-compose files references to the right dockerfile location.

Other files and URLs

Relationships

Help on issue template

Preview to follow the link or open file .github/ISSUE_DOC.md

fchauvel commented 5 years ago

Thanks for the feedback.

Is the docker-compose.yml file that is correctly modified, identical to the original one (in the template directory)?

mboussaa commented 5 years ago

Hi Frank,

Exactly. You can refer to this project to reproduce the bug: https://github.com/STAMP-project/camp/blob/master/samples/stamp/activeeon/camp.yml#L25

fchauvel commented 5 years ago

I'll look at it and let you know when I got a fix. Probably early next week.

fchauvel commented 5 years ago

I'm able to reproduce the problem you have, but unfortunately, fixing it entails deeper changes than I initially thought. We have to think about how and when to address this.