search

STAMP-project / dspot

Automatically detect and generate missing assertions for Junit test cases (also known as test amplification)
https://dspot-demo.stamp-project.eu/
GNU Lesser General Public License v3.0
114 stars 28 forks source link

Support passing required extra Maven configuration to DSpot #757

Open jesus-gorronogoitia opened 5 years ago

jesus-gorronogoitia commented 5 years ago

Characteristics

Description

Atos UC Supersede IF module needs to be build with Maven by accessing some repositories whose access is restricted by credentials. As these credentials cannot be included in the pom.xml they are encoded in a settings.xml that is passed to Maven using its -s flag. The point is that this configuration (-s settings.xml) is not passed to the forked Maven executions requested by DSpot, and hence failing as the dependencies are not resolved), so I wonder it could be possible to improve DSpot parameterization to incorporate another DSpot flag to pass additional Maven configuration that should be passed to any internal (to DSpot) Maven invocation.

Steps to reproduce

Properties file
Command Line / Options

Other files and URLs

Relationships

Help on issue template

Preview to follow the link or open file .github/ISSUE_DOC.md

danglotb commented 5 years ago

Hi @jesus-gorronogoitia

Thank you for the issue.

A way to do this is to extend the usage of the property maven.pre.goals.

I'll open a pull request ASAP with this new feature.

jesus-gorronogoitia commented 5 years ago

Hi @danglotb I've been able to fix this issue in our Jenkins CI by setting correctly the default settings.xml. Nonetheless, if you don't mind, I prefer to keep it open, with low priority, in case you eventually have time to implemented, because I think this feature is important to pass parameters to Maven if needed when DSpot is executing the forked Maven executions. Thanks a lot.