Integrationtests2

[nicolabertazzo]

11 replace .sh tests with Java integration tests using org.apache.maven.shared:maven-verifier

@CaelInria please check the class https://github.com/nicolabertazzo/pitmp-maven-plugin/blob/integrationtests2/src/test/java/org/pitest/maven/PmpMojoIT.java

In this class I check pit and pitmp compatibility. The verify goal works in Linux and Windows System.

I suggest to replace all the .sh tests with tests implemented in Java.

[Cael35]

Finally I have some time to review your Pull Request. :-)

• So I tried your Pull Request and maybe I missed something but "mvn test" executes only:

  [INFO] -------------------------------------------------------
  [INFO]  T E S T S
  [INFO] -------------------------------------------------------
  [INFO] Running eu.stamp_project.interceptors.DiffMutationFilterFactoryTest
  [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.027 s - in eu.stamp_project.interceptors.DiffMutationFilterFactoryTest
  [INFO] Running eu.stamp_project.interceptors.DiffInfoTest
  [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 s - in eu.stamp_project.interceptors.DiffInfoTest
  [INFO] Running eu.stamp_project.report.PseudoPartialyTestingListenerTest
  [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 s - in eu.stamp_project.report.PseudoPartialyTestingListenerTest
  [INFO] 
  [INFO] Results:
  [INFO] 
  [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
  [INFO] 
  [INFO] ------------------------------------------------------------------------
  [INFO] BUILD SUCCESS
  [INFO] ------------------------------------------------------------------------
  [INFO] Total time: 7.341 s
  [INFO] Finished at: 2018-10-17T18:28:54+02:00
  [INFO] Final Memory: 36M/1098M
  [INFO] ------------------------------------------------------------------------

  And not the equivalent of the script

• Did you just move the projects dhell, dhell5, dnoo, dnoo5 from test_dir into test/resources ?

• I reviewed the class PmpMojoIT.java and it's OK to use the Maven Verifier, but :

  • the test source shall not specify the PIT and PitMP versions. Actually the test script extracted the versions from the file pom.xml.
  • why is it in the package org.pitest.maven ?

• You should anyway use the maven-plugin-testing-harness. I had a look in dependencies and to use this plugin you need to use JUnit 3; PIT dependencies are:

  • maven-plugin-testing-harness version 1.1 depends on JUnit 3.8.1
  • maven-verifier version 1.5 depends on JUnit 3.8.2
    Since version 1.1 is the latest version of maven-plugin-testing-harness we need to use JUnit 3 to test PitMP.

[Cael35]

So i ran:

mvn -Pverify install

and it failed mvn_install_verify.txt And anyway we don't need the profile any more. The profile was introduce because of Windows incompatibility, but with the Verifier approach, it shall be ran without the profile by 'mvn install'

Before merging the following issues shall be fixed:

• 'mvn install' shall run the verifier and it should succeed
• class PmpMojoIT.java shall use the PIT and PitMP versions of the pom.xml
• use JUnit 3 to test PitMP and be able to use the maven-plugin-testing-harness

[Cael35]

The integration tests will be moved into another Maven project