STARIONGROUP / COMET-IME-Community-Edition

The Concurrent Design Desktop Application and Excel Integration compliant with ECSS-E-TM-10-25 Annex A and Annex C
https://www.stariongroup.eu
Other
21 stars 5 forks source link

After filtering and sorting in the ED browser, the COMET-IME may crash #1264

Closed samatstariongroup closed 11 months ago

samatstariongroup commented 1 year ago

Prerequisites

Description

Closing the element definitions browser still causes COMET to freeze and/or crash (this seems to be more likely to happen if I have applied some filtering & sorting in the browser or expanded some drop-down lists)

Steps to Reproduce

open a model, naviage to the ED browser and apply filtering and sorting and expand various drop-down lists

Logs

System Configuration

alexatstariongroup commented 11 months ago

Particularly sorting. Reproduction shown by ESA. Sorting on any column, and then trying to close the ED browser makes it hang. Reproduced by @lxatrhea on local machine.

alexatstariongroup commented 11 months ago

Update: seems that the problem is persistent to other browsers as well.

lxatstariongroup commented 11 months ago

This happens when RevisionNumber is reset to 0 for all ViewModels in the IME. This typically happens on Dispose of the Browser. Somehow, the NotifyChanged event is handled by DevExpress and some code is executed when a filter or sort is active on a TreeListControl, which leads into a repaint/refresh of the UI.

MartinFijneman commented 10 months ago

verified with 9.6.0.0

various tests performed which would lead to crash, now not happening anymore, ED browser correctly disposed

samatstariongroup commented 10 months ago

this fix is for all views that provide the mentioned filtering and sorting capability and is not limited to the ED only