STARIONGROUP / COMET-IME-Community-Edition

The Concurrent Design Desktop Application and Excel Integration compliant with ECSS-E-TM-10-25 Annex A and Annex C
https://www.stariongroup.eu
Other
22 stars 5 forks source link

Parametric Constraint's last relational expression must not be removed #267

Closed MartinFijneman closed 4 years ago

MartinFijneman commented 4 years ago

Prerequisites

Description

remove parametric constraint if only or last relational expression is removed

Currently, when removing (a) relation expression(s), the parametric constraint remains as empty placeholder. It would be better to remove the parent parametric constraint when it only has 1 relation expression and this is being removed.

Steps to Reproduce

Logs

System Configuration

lxatstariongroup commented 4 years ago

@MartinFijneman

This would be the 3rd way of handling the deletion of child things in the Requirement system: 1) In the ParametricConstraint editor it seems like you can't delete the last RelationalExpression

2) When the last RelationalExpression is deleted from a parent BooleanExpression (AND, OR, etc) the parent BooleanExpression shows an error overlay.

3) Now you want an automatic delete action for the parent Parametric constraint.

Could we standardize the way we implement this?

samatstariongroup commented 4 years ago

@lxatrhea and @MartinFijneman, 10-25 dictates the following:

ParametricConstraint.expression | BooleanExpression [1..*] {composite}

so, there needs to be at least one BooleanExpression in a ParametricConstraint.

We shall not allow a user to delete the last BooleanExpression, this needs to be enforced by both the UI and the server. If the intention of the user is to delete the ParametricConstraint, (s)he should do just that,