Inconsistencies in the migration flow using SAT version 1.4.2

[nlmave]

Prerequisites

• [x] I have written a descriptive issue title
• [x] I have verified that I am running the latest version of the CDP4-SDK
• [x] I have searched open and closed issues to ensure it has not already been reported

Description

We are running a comparison on the data migration performed at ESA from OCDT v3 to COMET. We noticed some inconsistencies in the migrated data that need to be looked at:

1. The publication time and date of the iterations are not kept
2. The iteration revision numbers differ
3. The iterations appear in different order

A detailed description will be sent by e-mail (cannot be connected to ticket for confidentiality reasons).

Steps to Reproduce

The issue appeared after full migration of the ESA CDF production data. Status has been reported off-line with ENEA and RHEA. Cannot be added to ticket as it contains proprietary information.

System Configuration

• [x] CDP4-Server-Administration-Tool version: 1.4.2
• [x] Environment (Operating system, version and so on): Windows 2019 Server Datacenter
• [x] .NET Framework version: compliant to SAT requirements
• [x] Additional information:

[adrianchivu]

ENEA (@adrianchivu / @cozminvelciu) will do the investigation.

[cozminvelciu]

Regarding "The iteration revision numbers differ", as @alexatrhea said:

Internally OCDT and COMET have very different automatic mechanisms that increment the revision numbers. At the same time I cant really think why it would be absolutely necessary to keep the revision numbers identical on the target system.

[cozminvelciu]

Regarding "The publication time and date of the iterations are not kept":

• the problem is not that the publication time and date of the iterations are not kept, but that they are displayed in the UI in a different order, which will appear like the publication on the same index has a different date, while it's just that it's in a different place in the grid
• the explanation for this is the same as for the "The iterations appear in different order" issue

These two issues are caused by the same thing: the properties on which these are based (EngineeringModelSetup.IterationSetup and Iteration.Publication) are not defined in 10-25 as ordered, which means that the ordering in which they will appear in the UI is arbitrary (not guaranteed to be the insertion order - this is especially relevant in the case of the migration, as normally these values would be naturally stored in the order they are created, while during the migration they are stored in bulk).

The reason this seems like a problem is:

• on ConCORDE, the UI [wrongly] expects that the values in the aforementioned array properties are ordered, while 10-25 offers no such guarantee - this makes it seem like the ordering, which is based on the index in the array, is wrong:

  public int PublicationNumber
  {
    get { return ((Iteration)this.Container).Publication.ToList().IndexOf(this) + 1; }
  }

• on COMET IME, the UI just displays the values in the aforementioned array properties as they are found

Note that this would apply to all non-ordered array properties, but which are expected to be ordered and displayed as such.

As a possible solution, for PublicationNumber:

• on ConCORDE, remove the assumptions that those arrays should be ordered, and just display them ordered by an agreed upon criteria (e.g. date)
• on IME, just display the items by default ordered by the same criteria

As a possible solution, for IterationNumber:

• since this is defined as a read-only property in 10-25, make sure that COMET WebServices properly assigns this property based on the CreatedOn date - I believe this is currently not done properly for migrated models

[samatstariongroup]

simple fix in the UI would be to order these by the date property (that makes sense for user)

[adrianchivu]

simple fix in the UI would be to order these by the date property (that makes sense for user)

Correct.