search

STARIONGROUP / COMET-WEB-Community-Edition

The CDP4-COMET web application
https://www.stariongroup.eu
GNU Affero General Public License v3.0
1 stars 1 forks source link

[3D Viewer] improvements on spacing and parameter editor #347

Closed samatstariongroup closed 2 months ago

samatstariongroup commented 1 year ago

Prerequisites

Description

The 3D viewer page needs to be improved in 3 places:

  1. improve spacing between treeview and scene, it can be made to look more visually appealing
  2. only enable the button when the provided value in the field is different from what we know the value to be in the cache
  3. use the same editor control as in the parameter editor. Now we cannot see which value it is we are editing (manual, reference, computed) nor what the switch is

image

Steps to Reproduce

NA

Logs

System Configuration

jaimeatstariongroup commented 1 year ago

@samatrhea

  1. I think that's already done. When the values change the button will appear blue.
  2. That's done in purpose because the value that you are going to edit in the 3DViewer is always going to be the manual. This is the only thing that makes sense for me. However it can be implemented.
joao4all commented 2 months ago

@samatrhea 2. I think that's already done. When the values change the button will appear blue. 3. That's done in purpose because the value that you are going to edit in the 3DViewer is always going to be the manual. This is the only thing that makes sense for me. However it can be implemented.

For 2, I can confirm it is already done. For 3, I agree with Jaime, since the 3D Viewer works with manual, it's more natural to edit only that switch, plus we can update values from different switches in Parameter Editor page already