STARIONGROUP / COMET-WebServices-Community-Edition

The Concurrent Design Platform Web Services that are compliant with ECSS-E-TM-10-25 Annex A and Annex C
https://www.stariongroup.eu
Other
11 stars 5 forks source link

Protocol should be updated to not allow person to de-active himself or change permissions #152

Closed MartinFijneman closed 8 months ago

MartinFijneman commented 4 years ago

Prerequisites

Description

Currently it is possible for a person to de-activate himself. This can lead to a lock-out situation where there is no person with sufficient permissions to activate persons again (see example below).

The protocol should be updated so that persons are not allowed to de-activate themselves (and change their own permissions?)

Example: tested on public server, where the normal admin-user existed next to a testing user as domain expert (i.e. with no permissions to edit other persons).

The admin-user can now still perform tasks as long as he is connected. After deconnecting from the session however, the admin-user is not allowed in. This situation cannot be restored.

Please note that this test was performed on the public server (is not yet on 6.0.0 RC5)

Implementation:

Steps to Reproduce

see above. Needs testing on server that can be deleted/restored after performing these steps

System Configuration

samatstariongroup commented 3 years ago

potential fix: update Person side-effect, when own person, do not allow updates of IsActive property (throw invalidoperationexception)