Propose different implementation for change of single domain that is assigned to a participant to allow in 1 edit operation - Githubissues

STARIONGROUP / COMET-WebServices-Community-Edition

The Concurrent Design Platform Web Services that are compliant with ECSS-E-TM-10-25 Annex A and Annex C

https://www.stariongroup.eu

Other

11 stars 5 forks source link

Propose different implementation for change of single domain that is assigned to a participant to allow in 1 edit operation #153

Open MartinFijneman opened 4 years ago

MartinFijneman commented 4 years ago

Prerequisites

[X] I have written a descriptive issue title
[X] I have verified that I am running the latest version of the CDP4 Web Services
[X] I have searched open and closed issues to ensure it has not already been reported

Description

question on implementation, not sure if this is a bug, or intended (and I’m missing something).

Situation is the following:

person with default domain e.g. “configuration”
created as participant, gets that domain
then edit participant, to move to other domain, e.g. Data-Handling: not possible at once, gives message: The CDP4 Services replied with code Forbidden: Forbidden: "exception:Participant selected domain must be contained in participant domain list."

For all I know, a participant should be able to represent any domain (not only its default one), so in the IME I expect to be able to do this.

On further testing, I found out that it is actually possible to change domain, but this needs 2 edits:

assign to 2nd domain and close dialog
edit again to remove from 1st domain

Is it possible to implement this differently so that changing a domain can be done in one go?

Solution: Two-step "transaction". Try to create a more generic server side solution for this. Otherwise, implement it in the IME.

Steps to Reproduce

can be reproduced with any model with any 2 domains

System Configuration

CDP4 Web Services version:
- [x] CDP4Common: 6.0.0. RC5
- [ ] PostrgreSQL:
- [ ] Other:
Environment (Operating system, version and so on):
.NET Framework version:
Mono version:
Additional information:

samatstariongroup commented 4 years ago

The server checks that there is at least one domain assigned to a participant. I have the impression that it is checking to delete one domain and sees if that when it does this the domains will become zero, so the operation fails. Not sure how to resolve this in a generic manner. The solution, in principle, would be to add the 2nd domain and then remove the 1st domain.