Data import flow does not validate cyclic dependencies

[cozminvelciu]

Description

The data import route does not validate in any way the input Annex C.3 zip archive for cyclic dependencies. If [a model in] the archive given as input contains cyclic dependencies, the WebServices server accepts it without any error or warning and creates the necessary databases.

In my case, I had a cyclic ParameterGroup, but I assume this can be reproduced with any of the possible data cycles.

If opening said model afterwards, when trying to interact (e.g. inspect) with the cyclic thing (tested with a ParameterGroup), the client/addin just hangs, presumably entering an infinite loop - after which it crashes and restarts.

This issue is reported here and not in the SAT as the only implementation for cycle validation is done in server-side side-effects on update operations.

Steps to Reproduce

1. Migrate a model (using SAT) containing a cyclic dependence
2. Open previously mentioned model afterwards in the addin
3. Interact (e.g. inspect) with the cyclic thing (tested with a ParameterGroup)
4. The addin hangs, after which it crashes and restart

System Configuration

Docker compose setup with services v6.1.4.

[adrianchivu]

As discussed with @alexatrhea:

• The proper way to handle this is to fix the model on the source server.
• If this is not possible then we should let the migration flow to migrate the model(s) to the COMET server as it does now for preservation purposes.
• Client side issues with the broken models should be investigated in separate task(s) when encountered.
• Long term: SAT and WebServices should be extended to support administrators in fixing cyclic problems in (semi) automatic approach.

[cozminvelciu]

Tagging @nlmave here for input.