STARIONGROUP / reqifsharp

A C# library for reading and writing reqif documents
https://reqifsharp.org
Apache License 2.0
24 stars 14 forks source link

RelationGroup should contain target identifier, currently only target object #10

Closed Helmut-Ortmann closed 5 years ago

Helmut-Ortmann commented 6 years ago

Prerequisites

Description

Feature request: Access to target identifier in RelationGroup(if target object isn't available in *.reqif file, external link)

Given a *.reqif file with a RelationGroup where the target object isn't part of the reqif file (external link). It would be nice to get the identifier of that target object (SpecObject).

New/Changed Interface: string CoreContent[i].SpecRelations.TargetIdentifier or so

The xml snippet. The identifier 'x0400000001330720' isn't specified in *.reqif. It's part of another file. `

x0400000001330720 x040000000133073F SPECREL

`

Steps to Reproduce

only Interface extension.

System Configuration

samatstariongroup commented 5 years ago

we'll look into it, thanks for the suggestion. @naronatrhea if you have some time, can you check this?

naronatrhea commented 5 years ago

in the next release, such not-found references will not be null anymore but will represent an object of the right type (Specification for RelationGroup and SpecObject for SpecRelation) that only has their identifier set with a description mentioning that the reference could not be found.

samatstariongroup commented 5 years ago

Dear @Helmut-Ortmann, we published a new release on nuget which includes the requested functionality https://www.nuget.org/packages/ReqIFSharp/1.4.0 let us know if you need anything else

Helmut-Ortmann commented 5 years ago

Thanks a lot for your fast and competent action.

Best regards,

Helmut