STAT210-S23 / Parsons_Paper_Register

1860's register of the Parsons Paper Company (Holyoke, MA)
GNU General Public License v3.0
0 stars 2 forks source link

Write Function to Search for Missing Parson's Paper page numbers #20

Closed kjinsanity closed 1 year ago

kjinsanity commented 1 year ago

Enumerate from 000 to 396 and output the missing values. This should match the pages we know are missing

nicholasjhorton commented 1 year ago

My thought:

Hopefully this should match the list in https://github.com/STAT210-S23/Parsons_Paper_Register/blob/main/README.md

Shall I proceed with the implementation?

kjinsanity commented 1 year ago

I was working on creating this method, and I also used some of the ideas presented above as well to create a test function that seems to have the desired output.

Will run this function on the modified .tiff files after further examination

nicholasjhorton commented 1 year ago

@kjinsanity can you please run the function on the files in https://github.com/STAT210-S23/Parsons_Paper_Register/tree/main/jpeg?

kjinsanity commented 1 year ago

Comparing the output of my function (from this file to the list mentioned above, we are missing a few images. More specifically, it seems that 371-376 and 395 are missing for now

nicholasjhorton commented 1 year ago

This is most helpful. I've tracked down those loose ends. Can you please run one more time then close the issue? I'm suspecting that the only missing pages will then be:

It would be helpful to include a brief discussion of this issue (and your code) in #26

kjinsanity commented 1 year ago

Screenshotted my results below, it seems that we are still missing pages 368 and 395

image

nicholasjhorton commented 1 year ago

368 seems to be missing. I've added it to #16.

I've tracked down 395. Thanks again for your work on this front!