STAT210-S23 / Parsons_Paper_Register

1860's register of the Parsons Paper Company (Holyoke, MA)
GNU General Public License v3.0
0 stars 2 forks source link

identify next steps or additional work on Parsons Paper ancestry.com project #23

Closed nicholasjhorton closed 1 year ago

nicholasjhorton commented 1 year ago

This issue will be closed when next steps (potentially in new issues) are identified to finish up work on the Parsons Paper ancestry.com initiative.

This will want to include:

See also #5

nicholasjhorton commented 1 year ago

Some issues I see in the current draft https://github.com/STAT210-S23/Parsons_Paper_Register/blob/main/addresses_exploration/workers_database.pdf

nicholasjhorton commented 1 year ago

Do you have a punch list for next steps for the report? As you know, the draft is due on Friday. I'd be glad to take a look at anything in advance of class I can do so if you add a comment to this issue by noon on Thursday.

My main suggestions are to:

Overall this is coming along well but further polishing and refinement will be helpful.

Cheafitz25 commented 1 year ago

Hello Professor, Lorraine and I will work to incorporate your edits and suggestions along with Eileen's. I think we can write more about the Allen family given what we discovered on the field trip. Additionally, we can divide the report into two sections; the first would detail the Allen family and the registry. The second section will be the technical aspects such as how we found the information using Ancestry.com. I think for your suggestion of adding a map, we may need help.

nicholasjhorton commented 1 year ago

This sounds like an excellent plan.

In terms of mapping, I'd be glad to assist. See https://rstudio.github.io/leaflet/

library(tidyverse)
library(leaflet)
m <- leaflet() %>%
  addTiles() %>%  # Add default OpenStreetMap map tiles
  addMarkers(lng=174.768, lat=-36.852, popup="The birthplace of R")
m  # Print the map
nicholasjhorton commented 1 year ago

I've pushed the pdf of the updated Quarto file.

nicholasjhorton commented 1 year ago

But I see that it hasn't changed much: I'll hold off on my review.

nicholasjhorton commented 1 year ago

Happy Friday!

Can you please:

  1. share an update on what you've been working on since we met yesterday, and
  2. add a comment for me in this issue when you are ready for my review?
nicholasjhorton commented 1 year ago

I've shared feedback under separate cover. Can you please revise and close this issue (anytime before the end of the day on Monday, March 27th)?

nicholasjhorton commented 1 year ago

@LorraineOloo wrote: We are unable to directly include the locations on the map if we want to print a pdf. If we set print to html only, then it is possible to include the addresses. Please let us know how you wnat us to proceed.

Is the issue that you are using leaflet to generate your maps? If so, I would suggest moving to openstreetmap or similar interface to ggmap to allow you to directly generate a PDF. There are some examples in https://mdsr-book.github.io/mdsr2e/ch-spatial.html

nicholasjhorton commented 1 year ago

final revision to Parsons Paper Company reports due by the end of the day on Wednesday, March 29th: can you please let me know if you have any questions as you finish up your work? @LorraineOloo and @Cheafitz25?

nicholasjhorton commented 1 year ago

Are you all set for me to proceed with my review? Thanks in advance for any guidance, Nick

Cheafitz25 commented 1 year ago

Yes apologies, I will close the issue now.

nicholasjhorton commented 1 year ago

I'm unable to read the file: can you please confirm that the pdf you pushed (https://github.com/STAT210-S23/Parsons_Paper_Register/blob/main/addresses_exploration/workers_database.pdf) is valid? Thanks in advance, Nick

LorraineOloo commented 1 year ago

It should be fixed now.