search

STAT325-S24 / HistoryAmherstCollege

Text and analysis related to Williams S. Tyler's "History of Amherst College" (1873)
MIT License
0 stars 1 forks source link

Get images #10

Closed Casey308 closed 5 months ago

Casey308 commented 6 months ago

There are many images in the text that right now are inaccessible, since we just scanned the text. Is there something we can do about this?

This issue will be closed when the images are added to the repo and described in some fashion.

nicholasjhorton commented 6 months ago

I believe that it should be straightforward to create screenshots of the images from the scanned pdf. This is not a top priority task but one that can be done in parallel to others.

nicholasjhorton commented 5 months ago

This can easily be done in parallel. But some questions: where to store the images? What file format? Naming format?

nicholasjhorton commented 5 months ago

What about putting these into inst/extdata? This would facilitate their use in a data package (see #1).

nicholasjhorton commented 5 months ago

Questions:

  1. what file format? (jpg? png?)
  2. what naming scheme (page_0XX.png?)
  3. how to deal with the Figure captions.
Casey308 commented 5 months ago

This is hopefully done with https://github.com/STAT325-S24/HistoryAmherstCollege/commits/main/. I named the images based on the page in the PDF, so that reviewing them might be easier (plus they don't have page numbers in the book). How does this look?

nicholasjhorton commented 5 months ago

@Casey308 this looks great. Here's the commit that I reviewed: https://github.com/STAT325-S24/HistoryAmherstCollege/commit/56cec01d9ebcceabe9e5211613d6e332a6fd3d82

Casey308 commented 5 months ago

Made a slight fix to one file name with: https://github.com/STAT325-S24/HistoryAmherstCollege/commit/03f47ebb537ed22103af2b39f83d5ff3a0865c82. Closing the issue now.