search

STAT325-S24 / HistoryAmherstCollege

Text and analysis related to Williams S. Tyler's "History of Amherst College" (1873)
MIT License
0 stars 1 forks source link

split text into separate chapters #12

Closed nicholasjhorton closed 5 months ago

nicholasjhorton commented 5 months ago

The https://github.com/STAT325-S24/HistoryAmherstCollege/blob/main/data-raw/amherst_history.txt is cumbersome to work with since it's monolithic.

I propose to create separate chapters that can be worked on in parallel (e.g., to address footnotes #7).

This issue will be closed when a script is added to data-raw with the output as well as the individual chapter files.

nicholasjhorton commented 5 months ago

Done via https://github.com/STAT325-S24/HistoryAmherstCollege/issues/12

@Casey308 can you please review and let me know if you see any issues? If no issues, can you please close this issue?

Casey308 commented 5 months ago

This was done by Nick with https://github.com/STAT325-S24/HistoryAmherstCollege/commit/f3a9f0240d9fb9238c468bb6c43dc4cab87aee1b.

Casey308 commented 5 months ago

Sorry for the delayed feedback. I wonder if we should split the appendix into its own chapter? Besides that it all looks good.

nicholasjhorton commented 5 months ago

That's a great suggestion.

Might you be willing to implement it?

Casey308 commented 5 months ago

Done with https://github.com/STAT325-S24/HistoryAmherstCollege/commit/62d28aadad5bc5efe6947394c7c65e5920764283. Closing this now.

nicholasjhorton commented 5 months ago

Thanks for your work on this front: the commit looks great.