search

STAT325-S24 / HistoryAmherstCollege

Text and analysis related to Williams S. Tyler's "History of Amherst College" (1873)
MIT License
0 stars 1 forks source link

fix footnotes for chapters 03-06 #15

Closed nicholasjhorton closed 5 months ago

nicholasjhorton commented 5 months ago

This issue will be closed when someone has updated the footnotes in these chapters and someone else has reviewed the pull request.

nicholasjhorton commented 5 months ago

@nicholasjhorton will review Adam's work.

arogers24 commented 5 months ago

https://github.com/STAT325-S24/HistoryAmherstCollege/commit/01ff335da89f95f84321cc38f7894042639775d9 There is a footnote on page 63 that I cannot find. Also, there is a random "5" at the bottom of page 65. It's also in the pdf, so I left it. There was also a missing page heading for page 72 that I added in

Casey308 commented 5 months ago

I saw a lot of random numbers at the bottom of pages in my chapters too, and they seemed to be counting up (18, 19 ...). Does anyone know what these are?

Casey308 commented 5 months ago

@nicholasjhorton, have you reviewed this work? If it looks good could you please close this issue?

nicholasjhorton commented 5 months ago

This looks great, modulo two minor comments. @arogers24 can you please the two remaining issues I tagged in your commit then close this issue?

nicholasjhorton commented 5 months ago

Any updates on this front? Thanks in advance for any guidance @arogers24

arogers24 commented 5 months ago

@nicholasjhorton I only saw one comment for the typo "presideint." I committed and pushed the change (https://github.com/STAT325-S24/HistoryAmherstCollege/commit/3faef5eaa84c8d14111535d9cb92709696b78b63). You said there was another one, but I couldn't find it.

nicholasjhorton commented 5 months ago

Thanks!

I concur that I could only see one comment. I'm closing the issue.