search

STAT325-S24 / HistoryAmherstCollege

Text and analysis related to Williams S. Tyler's "History of Amherst College" (1873)
MIT License
0 stars 1 forks source link

fix footnotes in chapters 19-23 #19

Closed nicholasjhorton closed 5 months ago

nicholasjhorton commented 5 months ago

This issue will be closed when someone has updated the footnotes in these chapters and someone else has reviewed the pull request.

nicholasjhorton commented 5 months ago

@Casey308 to review Tyler's work

tknightly24 commented 5 months ago

There is a line (line 296) in chapter 20 that I was not sure was a footnote. And if it is, I am not sure how I would go about fixing it. Any guidance or opinion as to how we should address it would be much appreciated. 43f016a

tknightly24 commented 5 months ago

Similarly, for chapter 22, on line 1013 there is a 1 (presumably representing a footnote), however there is no footnote that corresponds to it. I will need to know if we are either missing a footnote here or if the scan just copied an extra 1 here.

Casey308 commented 5 months ago

Based on looking in the PDF of the book it doesn't look like the chapter 20 one is a footnote, but the one in chapter 22 is. I've attached the footnote in question, so maybe we can just copy it from the PDF manually image

Casey308 commented 5 months ago

It seems that Nick and Justin have been putting the footnotes in brackets on a new line, but I don't think you did that Tyler. I don't know if that matters, but it may be helpful to stay consistent.

nicholasjhorton commented 5 months ago

@Casey308 I don't think that it's necessary to start a new line with the footnote, though it may be something to confirm as we finalize our workflow.

nicholasjhorton commented 5 months ago

PS I'm investigating the issues in chapters 20 and 22...

nicholasjhorton commented 5 months ago

Here's my proposed fix for chapter 20: can you please review @tknightly24?

nicholasjhorton commented 5 months ago

@Casey308 thanks for the screenshot: that was most helpful!

@tknightly24 here's my proposed fix: https://github.com/STAT325-S24/HistoryAmherstCollege/commit/b93e961c4ce327af268f5df7f61e84daef083807

Casey308 commented 5 months ago

This all looks good. I think we can close this issue now unless there were any lingering questions.