STAT325-S24 / HistoryAmherstCollege

Text and analysis related to Williams S. Tyler's "History of Amherst College" (1873)
MIT License
0 stars 1 forks source link

fix footnotes in chapters 24-28 #20

Closed nicholasjhorton closed 5 months ago

nicholasjhorton commented 5 months ago

This issue will be closed when someone has updated the footnotes in these chapters and someone else has reviewed the pull request.

nicholasjhorton commented 5 months ago

@tknightly24 to review Nick's work...

nicholasjhorton commented 5 months ago

@tknightly24 can you please take a look at my changes to chapter 24?

nicholasjhorton commented 5 months ago

@tknightly24 same for chapter 25. Just FYI, this took me about 10 minutes to convert.

tknightly24 commented 5 months ago

The footnotes for chapters 24 and 25 look good to me. I noticed you also fixed some of the page headings that didn't scan correctly; that is very helpful for our table in the code that removes the page breaks in the documents.

nicholasjhorton commented 5 months ago

Thanks for the review of chapters 24 and 25. I've checked these off above.

I've been working through missing page headings when I see them as well as typos and scan issues.

nicholasjhorton commented 5 months ago

See commits for chapter 26: https://github.com/STAT325-S24/HistoryAmherstCollege/commit/dc8ad122ce46d69cc239446f1312db88a54031e6

nicholasjhorton commented 5 months ago

And chapter 27: https://github.com/STAT325-S24/HistoryAmherstCollege/commit/f5772fc2135e7fd2a0b3b929bcdb29e101f9ddaf

Casey308 commented 5 months ago

Has chapter 28 been process yet?

nicholasjhorton commented 5 months ago

Alas, not yet. I'm hoping to process it soon.

nicholasjhorton commented 5 months ago

But I would encourage moving through the data processing with this as is (we can rerun the components again later this week).

nicholasjhorton commented 5 months ago

@tknightly24 I've belatedly finished up chapter 28: can you please review (then close this issue when you are done)?

Thanks in advance, Nick

tknightly24 commented 5 months ago

Chapter 28 looks good. I am closing the issue.

nicholasjhorton commented 5 months ago

Thanks!