review revised submission (was: issues with data loading in the report and Shiny app)

STAT325-S24 / MobyDick

Other

0 stars 2 forks source link

review revised submission (was: issues with data loading in the report and Shiny app) #16

Open nicholasjhorton opened 7 months ago

nicholasjhorton commented 7 months ago

Both the report and the Shiny app should access data from the package (not from https://github.com/STAT325-S24/MobyDick/tree/main/wrangling).

And these should migrate into data-raw.

Can you please update when you have a chance?

arogers24 commented 7 months ago

@nicholasjhorton I'm having some trouble adding this data to the package. It's having trouble finding "anno_moby.Rds." Do you have any suggestion on how I should do this?

arogers24 commented 7 months ago

https://github.com/STAT325-S24/MobyDick/commit/bfff52b97c6d97f2dd2afca52de6612bd70b123b @nicholasjhorton I've pushed the last changes given your suggestions. I believe this project is ready for review again!

nicholasjhorton commented 7 months ago

I'm on it!